Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bot initial list! #62

Merged
merged 5 commits into from
Oct 9, 2019
Merged

added bot initial list! #62

merged 5 commits into from
Oct 9, 2019

Conversation

grlwholifts
Copy link

@grlwholifts grlwholifts commented Oct 3, 2019

added the cli tests and relevant bot commands
#61
#59
committed changes via @nk521 from my local machine, hope you don't mind :)

cc: @s-yadav

@s-yadav
Copy link
Owner

s-yadav commented Oct 3, 2019

The order of contributors should be based on the number of the contribution he/she has made. Is there a way to automate that. Or it just depened on the order you add a contributor?

@grlwholifts
Copy link
Author

grlwholifts commented Oct 3, 2019

hi @s-yadav the order depends on the order the contributor is added in. I haven't played around with the bot enough to know of this based on no of contributions he/she has made. if you know, let me know so. I will implement it :)

@grlwholifts
Copy link
Author

hi, @s-yadav it would be great if you could review this sooner, in the review period. thanks!

@s-yadav
Copy link
Owner

s-yadav commented Oct 6, 2019

Sure will do before review period only.
We should check if things can be taken directly from github instead of manually adding this.
There is thread
all-contributors/cli#117

Also, can you look if there are any other tools for this?

@grlwholifts
Copy link
Author

@all-contributors please add @ruchikabgosain for adding this bot!

@grlwholifts
Copy link
Author

grlwholifts commented Oct 6, 2019

@all-contributors please add @ruchikabgosain for adding this bot!

We can add comments like this to add contributors :) @s-yadav
we only need to manually add them the first time the bot is getting configured.

@grlwholifts
Copy link
Author

hi @s-yadav the review period will be over today. could you please look into this?

@s-yadav s-yadav merged commit 7992908 into s-yadav:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants